Merged SqlFilestream #2398
Open
Merged SqlFilestream #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Small variable name changes to fit style of the wider library. * Made the EaNameString constant a compiler-level constant * Added extra validation to support drop-in .NET Framework replacement .NET Core compiles. Planning to use this as the baseline for the shared file.
…dAsync/WriteAsync methods. Also updated the refs project, although I think this'll be regenerated as part of the build.
…to an unrelated path
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2398 +/- ##
==========================================
- Coverage 72.69% 72.64% -0.05%
==========================================
Files 310 308 -2
Lines 61885 61535 -350
==========================================
- Hits 44988 44703 -285
+ Misses 16897 16832 -65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #1261.
This merges SqlFileStream between .NET Core and Framework. In the process, I've also implicitly dropped a code path to set the process-level or thread-level exception mode. This code path would set the thread-level exception mode on Windows 7 or higher, and the process-level exception mode on Windows XP or below; I've discarded the latter path.
SqlFileStream depends on a handful of PInvokes and a PathInternal class. I've merged these too, trimming unused methods where applicable. The removal of the former instances of these accounts for 70-80% of the removals.
I've also added ReadAsync and WriteAsync methods to SqlFileStream in .NET Core. The underlying FileStream supports these, so it doesn't do any harm to pass them through.